Revision of http://git.drupal.org/sandbox/ethanw/1369794.git from Tue, 12/13/2011 - 21:10
The revisions let you track differences between multiple versions of a post.
Review of the 6.x-1.x branch:
- Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards):
FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
22 | WARNING | Line exceeds 80 characters; contains 87 characters
--------------------------------------------------------------------------------FILE: ...view/sites/all/modules/pareview_temp/test_candidate/counter_api.install
--------------------------------------------------------------------------------
FOUND 5 ERROR(S) AND 2 WARNING(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
3 | ERROR | The second line in the file doc comment must be " * @file"
28 | ERROR | Comments may not appear after statements.
29 | ERROR | Comments may not appear after statements.
33 | WARNING | Line exceeds 80 characters; contains 85 characters
33 | ERROR | Comments may not appear after statements.
50 | ERROR | Comments may not appear after statements.
59 | WARNING | A comma should follow the last multiline array item. Found: )
--------------------------------------------------------------------------------FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/counter_api.module
--------------------------------------------------------------------------------
FOUND 89 ERROR(S) AND 9 WARNING(S) AFFECTING 63 LINE(S)
--------------------------------------------------------------------------------
3 | ERROR | The second line in the file doc comment must be " * @file"
6 | ERROR | Whitespace found at end of line
7 | ERROR | Whitespace found at end of line
12 | ERROR | Whitespace found at end of line
16 | ERROR | Whitespace found at end of line
20 | WARNING | Format should be * Implements hook_foo().
26 | WARNING | Line exceeds 80 characters; contains 84 characters
26 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 4
27 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
28 | ERROR | Inline control structures are not allowed
48 | WARNING | A comma should follow the last multiline array item. Found: )
53 | ERROR | Missing function doc comment
54 | ERROR | Inline comments must start with a capital letter
54 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
56 | ERROR | Inline comments must start with a capital letter
56 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
58 | WARNING | Line exceeds 80 characters; contains 150 characters
58 | ERROR | Inline comments must start with a capital letter
58 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
58 | ERROR | Comments may not appear after statements.
59 | ERROR | Whitespace found at end of line
61 | WARNING | Line exceeds 80 characters; contains 158 characters
61 | ERROR | No space before comment text; expected "// failed tick" but
| | found "//failed tick"
61 | ERROR | Inline comments must start with a capital letter
61 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
61 | ERROR | Comments may not appear after statements.
65 | WARNING | Line exceeds 80 characters; contains 113 characters
65 | ERROR | Inline comments must start with a capital letter
65 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
65 | ERROR | Comments may not appear after statements.
69 | ERROR | You must use "/**" style comments for a function comment
71 | ERROR | Inline comments must start with a capital letter
71 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
72 | ERROR | Empty array declaration must have no space between the
| | parentheses
74 | ERROR | Inline comments must start with a capital letter
74 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
78 | WARNING | Format should be * Implements hook_foo().
78 | ERROR | Expected 1 space(s) before asterisk; 0 found
79 | ERROR | Expected 1 space(s) before asterisk; 0 found
82 | ERROR | An operator statement must be followed by a single space
93 | ERROR | Whitespace found at end of line
94 | ERROR | Last parameter comment requires a blank newline after it
94 | ERROR | Parameter comment must be on the next line at position 1
95 | ERROR | Return comment must be on the next line
98 | ERROR | Inline comments must start with a capital letter
98 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
100 | ERROR | Inline comments must start with a capital letter
101 | WARNING | Line exceeds 80 characters; contains 83 characters
101 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
102 | ERROR | A cast statement must be followed by a single space
105 | ERROR | Inline comments must start with a capital letter
106 | ERROR | A cast statement must be followed by a single space
106 | WARNING | Line exceeds 80 characters; contains 105 characters
106 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
106 | ERROR | Comments may not appear after statements.
114 | ERROR | Whitespace found at end of line
115 | ERROR | Last parameter comment requires a blank newline after it
115 | ERROR | Parameter comment must be on the next line at position 1
116 | ERROR | Return comment must be on the next line
119 | ERROR | Inline comments must start with a capital letter
119 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
124 | ERROR | Inline comments must start with a capital letter
124 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
126 | ERROR | Inline comments must start with a capital letter
126 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
132 | ERROR | Whitespace found at end of line
133 | ERROR | Parameter comment must be on the next line at position 1
134 | ERROR | Last parameter comment requires a blank newline after it
134 | ERROR | Parameter comment must be on the next line at position 2
135 | ERROR | Return comment must be on the next line
137 | ERROR | An operator statement must be followed by a single space
137 | ERROR | There must be a single space before an operator statement
138 | ERROR | Inline comments must start with a capital letter
138 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
141 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
145 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
151 | ERROR | Whitespace found at end of line
153 | ERROR | Missing comment for @return statement
156 | ERROR | Inline comments must start with a capital letter
156 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
159 | ERROR | Inline comments must start with a capital letter
159 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
161 | ERROR | Inline comments must start with a capital letter
161 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
167 | ERROR | Whitespace found at end of line
168 | ERROR | Last parameter comment requires a blank newline after it
168 | ERROR | Parameter comment must be on the next line at position 1
169 | ERROR | Return comment must be on the next line
177 | ERROR | Whitespace found at end of line
178 | ERROR | Last parameter comment requires a blank newline after it
178 | ERROR | Parameter comment must be on the next line at position 1
179 | ERROR | Return comment must be on the next line
188 | ERROR | Whitespace found at end of line
189 | ERROR | Parameter comment must be on the next line at position 1
190 | ERROR | Last parameter comment requires a blank newline after it
190 | ERROR | Parameter comment must be on the next line at position 2
191 | ERROR | Missing comment for @return statement
197 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------FILE: ...mp/test_candidate/modules/counter_api_block/counter_api_block.admin.inc
--------------------------------------------------------------------------------
FOUND 17 ERROR(S) AND 1 WARNING(S) AFFECTING 14 LINE(S)
--------------------------------------------------------------------------------
4 | ERROR | Whitespace found at end of line
8 | ERROR | Whitespace found at end of line
35 | WARNING | Line exceeds 80 characters; contains 85 characters
58 | ERROR | Concat operator must be surrounded by spaces
112 | ERROR | Last parameter comment requires a blank newline after it
112 | ERROR | Missing parameter type at position 1
114 | ERROR | Data type of return value is missing
118 | ERROR | Inline comments must start with a capital letter
118 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
136 | ERROR | Last parameter comment requires a blank newline after it
136 | ERROR | Missing parameter type at position 1
139 | ERROR | Data type of return value is missing
144 | ERROR | Inline comments must start with a capital letter
145 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
183 | ERROR | Inline comments must start with a capital letter
183 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
191 | ERROR | Data type of return value is missing
202 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------FILE: ..._temp/test_candidate/modules/counter_api_block/counter_api_block.module
--------------------------------------------------------------------------------
FOUND 28 ERROR(S) AND 8 WARNING(S) AFFECTING 27 LINE(S)
--------------------------------------------------------------------------------
3 | ERROR | The second line in the file doc comment must be " * @file"
8 | WARNING | Format should be * Implements hook_foo().
14 | WARNING | Line exceeds 80 characters; contains 84 characters
14 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 4
20 | WARNING | Format should be * Implements hook_foo().
22 | ERROR | Whitespace found at end of line
52 | WARNING | Line exceeds 80 characters; contains 81 characters
61 | WARNING | Format should be * Implements hook_foo().
62 | ERROR | Whitespace found at end of line
63 | ERROR | Whitespace found at end of line
63 | ERROR | Missing comment for param "$existing" at position 1
64 | ERROR | Whitespace found at end of line
64 | ERROR | Missing comment for param "$type" at position 2
65 | ERROR | Whitespace found at end of line
65 | ERROR | Missing comment for param "$theme" at position 3
66 | ERROR | Whitespace found at end of line
66 | ERROR | Last parameter comment requires a blank newline after it
66 | ERROR | Missing comment for param "$path" at position 4
68 | ERROR | Return comment must be on the next line
74 | WARNING | A comma should follow the last multiline array item. Found: 0
75 | WARNING | A comma should follow the last multiline array item. Found: )
76 | WARNING | A comma should follow the last multiline array item. Found: )
82 | ERROR | Whitespace found at end of line
83 | ERROR | Whitespace found at end of line
83 | ERROR | Last parameter comment requires a blank newline after it
83 | ERROR | Missing comment for param "$counter_value" at position 1
85 | ERROR | Return comment must be on the next line
96 | ERROR | Missing parameter type at position 1
104 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
107 | ERROR | Whitespace found at end of line
108 | ERROR | No space found after comma in function call
123 | ERROR | Last parameter comment requires a blank newline after it
123 | ERROR | Missing parameter type at position 1
126 | ERROR | Data type of return value is missing
138 | ERROR | Expected 1 space after comma in function call; 7 found
143 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------FILE: ...test_candidate/plugins/export_ui/counter_api_ctools_export_ui.class.php
--------------------------------------------------------------------------------
FOUND 71 ERROR(S) AND 3 WARNING(S) AFFECTING 46 LINE(S)
--------------------------------------------------------------------------------
3 | ERROR | The second line in the file doc comment must be " * @file"
6 | ERROR | Whitespace found at end of line
9 | ERROR | Class name must begin with a capital letter
9 | ERROR | Class name must use UpperCamel naming without underscores
13 | ERROR | Method name "counter_api_ctools_export_ui::set_value_page" is
| | not in lowerCamel format, it must not contain underscores
15 | ERROR | Inline comments must start with a capital letter
15 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
17 | ERROR | Inline comments must start with a capital letter
25 | ERROR | No space found after comma in function call
29 | ERROR | Space found before comma in function call
29 | ERROR | No space found after comma in function call
29 | WARNING | Line exceeds 80 characters; contains 129 characters
29 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
29 | ERROR | Comments may not appear after statements.
41 | ERROR | Whitespace found at end of line
42 | ERROR | Whitespace found at end of line
42 | ERROR | Missing comment for param "$form" at position 1
43 | ERROR | Whitespace found at end of line
43 | ERROR | Last parameter comment requires a blank newline after it
43 | ERROR | Missing comment for param "$form_state" at position 2
45 | ERROR | Return comment must be on the next line
47 | ERROR | Method name "counter_api_ctools_export_ui::set_value_form" is
| | not in lowerCamel format, it must not contain underscores
64 | ERROR | Whitespace found at end of line
65 | ERROR | Whitespace found at end of line
65 | ERROR | Missing comment for param "$form" at position 1
66 | ERROR | Whitespace found at end of line
66 | ERROR | Last parameter comment requires a blank newline after it
66 | ERROR | Missing comment for param "$form_state" at position 2
68 | ERROR | Missing comment for @return statement
70 | ERROR | Method name
| | "counter_api_ctools_export_ui::set_value_form_validate" is not
| | in lowerCamel format, it must not contain underscores
78 | ERROR | Whitespace found at end of line
79 | ERROR | Whitespace found at end of line
79 | ERROR | Missing comment for param "$form" at position 1
80 | ERROR | Whitespace found at end of line
80 | ERROR | Last parameter comment requires a blank newline after it
80 | ERROR | Missing comment for param "$form_state" at position 2
82 | ERROR | Missing comment for @return statement
84 | ERROR | Method name
| | "counter_api_ctools_export_ui::set_value_form_submit" is not
| | in lowerCamel format, it must not contain underscores
88 | ERROR | No space found after comma in function call
94 | ERROR | Method name
| | "counter_api_ctools_export_ui::increment_value_page" is not in
| | lowerCamel format, it must not contain underscores
96 | ERROR | Inline comments must start with a capital letter
96 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
98 | ERROR | Inline comments must start with a capital letter
106 | ERROR | No space found after comma in function call
110 | ERROR | No space found after comma in function call
110 | WARNING | Line exceeds 80 characters; contains 214 characters
110 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
110 | ERROR | Comments may not appear after statements.
122 | ERROR | Whitespace found at end of line
123 | ERROR | Whitespace found at end of line
123 | ERROR | Missing comment for param "$form" at position 1
124 | ERROR | Whitespace found at end of line
124 | ERROR | Last parameter comment requires a blank newline after it
124 | ERROR | Missing comment for param "$form_state" at position 2
126 | ERROR | Return comment must be on the next line
128 | ERROR | Method name
| | "counter_api_ctools_export_ui::increment_value_form" is not in
| | lowerCamel format, it must not contain underscores
135 | WARNING | A comma should follow the last multiline array item. Found:
| | "The value of the counter as of this page being displayed.
| | Note this might change between the time this page is generated
| | and when you submit this form."
152 | ERROR | Whitespace found at end of line
153 | ERROR | Whitespace found at end of line
153 | ERROR | Missing comment for param "$form" at position 1
154 | ERROR | Whitespace found at end of line
154 | ERROR | Last parameter comment requires a blank newline after it
154 | ERROR | Missing comment for param "$form_state" at position 2
156 | ERROR | Missing comment for @return statement
158 | ERROR | Method name
| | "counter_api_ctools_export_ui::increment_value_form_validate"
| | is not in lowerCamel format, it must not contain underscores
163 | ERROR | Whitespace found at end of line
164 | ERROR | Whitespace found at end of line
164 | ERROR | Missing comment for param "$form" at position 1
165 | ERROR | Whitespace found at end of line
165 | ERROR | Last parameter comment requires a blank newline after it
165 | ERROR | Missing comment for param "$form_state" at position 2
167 | ERROR | Missing comment for @return statement
169 | ERROR | Method name
| | "counter_api_ctools_export_ui::increment_value_form_submit" is
| | not in lowerCamel format, it must not contain underscores
172 | ERROR | No space found after comma in function call
--------------------------------------------------------------------------------FILE: ..._temp/test_candidate/plugins/export_ui/counter_api_ctools_export_ui.inc
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AND 1 WARNING(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
19 | ERROR | Whitespace found at end of line
24 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
49 | ERROR | Inline comments must start with a capital letter
49 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
80 | WARNING | A comma should follow the last multiline array item. Found: )
80 | ERROR | Whitespace found at end of line
99 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.
Source: http://ventral.org/pareview - PAReview.sh online service
