http://git.drupal.org/project/blizzardapi.git 7.x-1.x
Primary tabs
Keep in mind that this is primarily a high level check that does not replace but, after all, eases the review process. There is no guarantee that no other issues could show up in a more in-depth manual follow-up review. This service depends on modules that are still under development and changed frequently hence the quality of automated reviews can vary from day to day.
Review of the 7.x-1.x branch:
- Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
- Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
sites/all/modules/pareview_temp/./test_candidate/includes/blizzardapi.tabard.inc:
+205: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
+207: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
+208: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
sites/all/modules/pareview_temp/./test_candidate/includes/blizzardapi.abstract.inc:
+386: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
Status Messages:
Coder found 6 projects, 6 files, 4 minor warnings, 0 warnings were flagged to be ignored
FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
10 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------
FILE: ...view/sites/all/modules/pareview_temp/test_candidate/blizzardapi.api.php
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AND 3 WARNING(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
25 | WARNING | A comma should follow the last multiline array item. Found:
| | 'fr'
27 | ERROR | Whitespace found at end of line
31 | ERROR | Whitespace found at end of line
43 | WARNING | A comma should follow the last multiline array item. Found: ]
47 | ERROR | Whitespace found at end of line
49 | WARNING | Line exceeds 80 characters; contains 94 characters
--------------------------------------------------------------------------------
FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/blizzardapi.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
10 | ERROR | It's only necessary to declare files[] if they declare a class or
| | interface.
--------------------------------------------------------------------------------
FILE: ...view/sites/all/modules/pareview_temp/test_candidate/blizzardapi.install
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AND 9 WARNING(S) AFFECTING 11 LINE(S)
--------------------------------------------------------------------------------
9 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar()."
13 | ERROR | Whitespace found at end of line
22 | WARNING | A comma should follow the last multiline array item. Found: ''
30 | WARNING | A comma should follow the last multiline array item. Found: 1
38 | WARNING | A comma should follow the last multiline array item. Found: 0
46 | WARNING | A comma should follow the last multiline array item. Found: 0
54 | WARNING | A comma should follow the last multiline array item. Found: 0
62 | WARNING | A comma should follow the last multiline array item. Found: 0
63 | WARNING | A comma should follow the last multiline array item. Found: )
65 | WARNING | A comma should follow the last multiline array item. Found: )
67 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------
FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/blizzardapi.module
--------------------------------------------------------------------------------
FOUND 31 ERROR(S) AND 15 WARNING(S) AFFECTING 45 LINE(S)
--------------------------------------------------------------------------------
13 | WARNING | Line exceeds 80 characters; contains 112 characters
44 | WARNING | A comma should follow the last multiline array item. Found: )
46 | ERROR | Whitespace found at end of line
52 | WARNING | A comma should follow the last multiline array item. Found: )
54 | ERROR | Whitespace found at end of line
63 | ERROR | Whitespace found at end of line
84 | ERROR | Whitespace found at end of line
91 | ERROR | String concat is not required here; use a single string
| | instead
94 | WARNING | A comma should follow the last multiline array item. Found:
| | '
'
96 | ERROR | Whitespace found at end of line
100 | ERROR | Whitespace found at end of line
105 | WARNING | A comma should follow the last multiline array item. Found:
| | $ssl_enabled
107 | ERROR | Whitespace found at end of line
112 | WARNING | Line exceeds 80 characters; contains 118 characters
112 | ERROR | Comments may not appear after statements.
114 | WARNING | A comma should follow the last multiline array item. Found:
| | $ssl_enabled
116 | ERROR | Whitespace found at end of line
119 | WARNING | A comma should follow the last multiline array item. Found: )
121 | ERROR | Whitespace found at end of line
128 | WARNING | A comma should follow the last multiline array item. Found: )
130 | WARNING | A comma should follow the last multiline array item. Found: )
132 | ERROR | Whitespace found at end of line
136 | WARNING | A comma should follow the last multiline array item. Found: )
138 | ERROR | Whitespace found at end of line
142 | WARNING | A comma should follow the last multiline array item. Found: )
144 | ERROR | Whitespace found at end of line
153 | ERROR | Whitespace found at end of line
158 | ERROR | Whitespace found at end of line
162 | ERROR | Whitespace found at end of line
189 | ERROR | Whitespace found at end of line
194 | ERROR | Whitespace found at end of line
202 | ERROR | Whitespace found at end of line
209 | ERROR | Whitespace found at end of line
219 | WARNING | A comma should follow the last multiline array item. Found:
| | perday_cached
222 | ERROR | Whitespace found at end of line
231 | ERROR | Whitespace found at end of line
234 | ERROR | Whitespace found at end of line
243 | WARNING | A comma should follow the last multiline array item. Found: )
246 | ERROR | Whitespace found at end of line
252 | WARNING | A comma should follow the last multiline array item. Found: )
254 | ERROR | Whitespace found at end of line
260 | ERROR | Whitespace found at end of line
265 | ERROR | Whitespace found at end of line
278 | ERROR | Return comment must be on the next line
282 | ERROR | Whitespace found at end of line
286 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------
FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/blizzardapi.test
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
9 | ERROR | Whitespace found at end of line
13 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------
FILE: .../modules/pareview_temp/test_candidate/includes/blizzardapi.abstract.inc
--------------------------------------------------------------------------------
FOUND 115 ERROR(S) AND 11 WARNING(S) AFFECTING 116 LINE(S)
--------------------------------------------------------------------------------
5 | ERROR | Whitespace found at end of line
14 | ERROR | Whitespace found at end of line
20 | ERROR | Whitespace found at end of line
30 | ERROR | Whitespace found at end of line
31 | ERROR | Private member variable "_schema" must not be
| | prefixed with an underscore - it is discouraged in PHP
| | 5-specific code
36 | WARNING | A comma should follow the last multiline array item. Found:
| | 'pt_BR'
43 | WARNING | A comma should follow the last multiline array item. Found:
| | 'de_DE'
47 | WARNING | A comma should follow the last multiline array item. Found: )
48 | WARNING | A comma should follow the last multiline array item. Found: )
50 | ERROR | Whitespace found at end of line
57 | ERROR | Whitespace found at end of line
61 | WARNING | Line exceeds 80 characters; contains 81 characters
66 | ERROR | Whitespace found at end of line
73 | ERROR | Whitespace found at end of line
80 | ERROR | Whitespace found at end of line
84 | ERROR | Whitespace found at end of line
85 | WARNING | Line exceeds 80 characters; contains 81 characters
86 | ERROR | Whitespace found at end of line
90 | ERROR | Whitespace found at end of line
99 | WARNING | Line exceeds 80 characters; contains 97 characters
107 | ERROR | Whitespace found at end of line
114 | ERROR | Whitespace found at end of line
123 | ERROR | Whitespace found at end of line
130 | ERROR | Whitespace found at end of line
139 | ERROR | Whitespace found at end of line
148 | ERROR | Whitespace found at end of line
155 | ERROR | No space before comment text; expected "//
| | $this->setLocale($region, $language);" but found
| | "//$this->setLocale($region, $language);"
157 | ERROR | Whitespace found at end of line
165 | ERROR | Whitespace found at end of line
171 | ERROR | Whitespace found at end of line
181 | ERROR | Whitespace found at end of line
185 | ERROR | Whitespace found at end of line
190 | ERROR | Whitespace found at end of line
192 | ERROR | Whitespace found at end of line
195 | ERROR | Whitespace found at end of line
201 | ERROR | Whitespace found at end of line
203 | ERROR | Whitespace found at end of line
207 | ERROR | Whitespace found at end of line
210 | ERROR | Whitespace found at end of line
212 | WARNING | Line exceeds 80 characters; contains 82 characters
217 | ERROR | Whitespace found at end of line
221 | ERROR | Whitespace found at end of line
224 | ERROR | Whitespace found at end of line
225 | ERROR | Function doc comment is empty
230 | ERROR | Whitespace found at end of line
234 | ERROR | Whitespace found at end of line
239 | ERROR | Use "elseif" in place of "else if"
242 | ERROR | No space before comment text; expected "// else if
| | (function_exists($filter) && ($filter($item[$key]) == TRUE))
| | {" but found "//else if (function_exists($filter) &&
| | ($filter($item[$key]) == TRUE)) {"
242 | ERROR | Inline comments must start with a capital letter
244 | ERROR | No space before comment text; expected "// }" but found "//}"
246 | ERROR | Whitespace found at end of line
249 | ERROR | Whitespace found at end of line
256 | ERROR | Whitespace found at end of line
259 | ERROR | Whitespace found at end of line
263 | ERROR | Whitespace found at end of line
267 | ERROR | Whitespace found at end of line
268 | WARNING | Line exceeds 80 characters; contains 84 characters
271 | ERROR | Whitespace found at end of line
274 | ERROR | Whitespace found at end of line
277 | ERROR | Whitespace found at end of line
281 | ERROR | Whitespace found at end of line
288 | ERROR | Whitespace found at end of line
292 | ERROR | No space before comment text; expected "// protected abstract
| | function getData();" but found "//protected abstract function
| | getData();"
292 | ERROR | Inline comments must start with a capital letter
292 | ERROR | There must be no blank line following an inline comment
293 | ERROR | Whitespace found at end of line
300 | ERROR | Whitespace found at end of line
307 | ERROR | Whitespace found at end of line
314 | ERROR | Whitespace found at end of line
322 | ERROR | Whitespace found at end of line
325 | ERROR | Whitespace found at end of line
332 | ERROR | Whitespace found at end of line
339 | ERROR | Whitespace found at end of line
341 | ERROR | Whitespace found at end of line
346 | WARNING | A comma should follow the last multiline array item. Found:
| | 'GET'
348 | ERROR | Whitespace found at end of line
354 | ERROR | Whitespace found at end of line
360 | ERROR | Whitespace found at end of line
361 | ERROR | No space before comment text; expected "// if
| | (isset($response->headers['last-modified'])) {" but found
| | "//if (isset($response->headers['last-modified'])) {"
361 | ERROR | Inline comments must start with a capital letter
363 | ERROR | No space before comment text; expected "// }" but found "//}"
363 | ERROR | There must be no blank line following an inline comment
364 | ERROR | Whitespace found at end of line
365 | ERROR | No space before comment text; expected "// if
| | (isset($response->headers['etag'])) {" but found "//if
| | (isset($response->headers['etag'])) {"
365 | ERROR | Inline comments must start with a capital letter
367 | ERROR | No space before comment text; expected "// }" but found "//}"
374 | ERROR | Whitespace found at end of line
377 | ERROR | Whitespace found at end of line
381 | ERROR | Whitespace found at end of line
388 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 4
388 | ERROR | No space before comment text; expected "// case 'deflate':"
| | but found "//case 'deflate':"
388 | ERROR | Inline comments must start with a capital letter
389 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 4
393 | ERROR | Whitespace found at end of line
395 | ERROR | Whitespace found at end of line
398 | ERROR | Comments may not appear after statements.
400 | ERROR | Whitespace found at end of line
405 | ERROR | Whitespace found at end of line
407 | ERROR | Comments may not appear after statements.
408 | ERROR | Comments may not appear after statements.
409 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
409 | ERROR | Comments may not appear after statements.
411 | ERROR | Whitespace found at end of line
416 | ERROR | Whitespace found at end of line
417 | WARNING | Line exceeds 80 characters; contains 91 characters
427 | ERROR | Whitespace found at end of line
431 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
431 | ERROR | Comments may not appear after statements.
434 | ERROR | Comments may not appear after statements.
435 | ERROR | Comments may not appear after statements.
437 | ERROR | Comments may not appear after statements.
438 | ERROR | Comments may not appear after statements.
441 | ERROR | Comments may not appear after statements.
445 | ERROR | Whitespace found at end of line
446 | ERROR | Function doc comment is empty
454 | ERROR | Whitespace found at end of line
457 | ERROR | Whitespace found at end of line
460 | ERROR | Whitespace found at end of line
464 | ERROR | Whitespace found at end of line
474 | ERROR | Whitespace found at end of line
475 | ERROR | Function doc comment is empty
483 | ERROR | Whitespace found at end of line
486 | ERROR | Whitespace found at end of line
488 | ERROR | Whitespace found at end of line
494 | ERROR | Whitespace found at end of line
506 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------
FILE: ...ll/modules/pareview_temp/test_candidate/includes/blizzardapi.tabard.inc
--------------------------------------------------------------------------------
FOUND 65 ERROR(S) AND 18 WARNING(S) AFFECTING 74 LINE(S)
--------------------------------------------------------------------------------
29 | ERROR | Whitespace found at end of line
30 | ERROR | Return comment must be on the next line
39 | ERROR | Whitespace found at end of line
44 | ERROR | Whitespace found at end of line
47 | ERROR | Comments may not appear after statements.
48 | ERROR | Comments may not appear after statements.
49 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
49 | ERROR | Comments may not appear after statements.
57 | ERROR | Whitespace found at end of line
68 | ERROR | Whitespace found at end of line
74 | ERROR | Whitespace found at end of line
76 | ERROR | Whitespace found at end of line
77 | WARNING | Line exceeds 80 characters; contains 87 characters
91 | WARNING | Line exceeds 80 characters; contains 83 characters
93 | WARNING | Line exceeds 80 characters; contains 81 characters
93 | ERROR | Return comment must be on the next line
99 | ERROR | Whitespace found at end of line
104 | WARNING | A comma should follow the last multiline array item. Found: )
108 | WARNING | A comma should follow the last multiline array item. Found: )
113 | WARNING | A comma should follow the last multiline array item. Found: ]
117 | WARNING | A comma should follow the last multiline array item. Found: )
122 | WARNING | A comma should follow the last multiline array item. Found: ]
127 | WARNING | A comma should follow the last multiline array item. Found: ]
131 | WARNING | A comma should follow the last multiline array item. Found: )
132 | WARNING | A comma should follow the last multiline array item. Found: )
134 | ERROR | Whitespace found at end of line
146 | ERROR | Whitespace found at end of line
150 | ERROR | Whitespace found at end of line
155 | ERROR | Whitespace found at end of line
166 | ERROR | Whitespace found at end of line
168 | ERROR | Whitespace found at end of line
174 | ERROR | Whitespace found at end of line
178 | ERROR | Whitespace found at end of line
184 | ERROR | Whitespace found at end of line
188 | ERROR | Whitespace found at end of line
192 | ERROR | Whitespace found at end of line
195 | ERROR | Whitespace found at end of line
204 | ERROR | Whitespace found at end of line
209 | ERROR | Whitespace found at end of line
213 | ERROR | Whitespace found at end of line
215 | ERROR | Whitespace found at end of line
219 | ERROR | Whitespace found at end of line
220 | ERROR | Inline comments must start with a capital letter
222 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
222 | ERROR | There must be no blank line following an inline comment
223 | ERROR | Whitespace found at end of line
224 | ERROR | Inline comments must start with a capital letter
224 | ERROR | There must be no blank line following an inline comment
225 | ERROR | Whitespace found at end of line
226 | ERROR | No space before comment text; expected "// $intensity = 19.0;"
| | but found "//$intensity = 19.0;"
227 | ERROR | No space before comment text; expected "// $blend = 1.0 /
| | 3.0;" but found "//$blend = 1.0 / 3.0;"
228 | WARNING | Line exceeds 80 characters; contains 93 characters
228 | ERROR | No space before comment text; expected "// $out[0] = $out[0] *
| | ($out[0] / 255 + $blend) + ($out[0] / $intensity + $out[0] *
| | $blend);" but found "//$out[0] = $out[0] * ($out[0] / 255 +
| | $blend) + ($out[0] / $intensity + $out[0] * $blend);"
229 | WARNING | Line exceeds 80 characters; contains 93 characters
229 | ERROR | No space before comment text; expected "// $out[1] = $out[1] *
| | ($out[1] / 255 + $blend) + ($out[1] / $intensity + $out[1] *
| | $blend);" but found "//$out[1] = $out[1] * ($out[1] / 255 +
| | $blend) + ($out[1] / $intensity + $out[1] * $blend);"
230 | WARNING | Line exceeds 80 characters; contains 93 characters
230 | ERROR | No space before comment text; expected "// $out[2] = $out[2] *
| | ($out[2] / 255 + $blend) + ($out[2] / $intensity + $out[2] *
| | $blend);" but found "//$out[2] = $out[2] * ($out[2] / 255 +
| | $blend) + ($out[2] / $intensity + $out[2] * $blend);"
230 | ERROR | There must be no blank line following an inline comment
231 | ERROR | Whitespace found at end of line
233 | ERROR | There must be no blank line following an inline comment
234 | ERROR | Whitespace found at end of line
238 | WARNING | A comma should follow the last multiline array item. Found: ]
240 | ERROR | Whitespace found at end of line
257 | WARNING | Line exceeds 80 characters; contains 81 characters
270 | ERROR | No space before comment text; expected "//
| | imagealphablending($image, TRUE);" but found
| | "//imagealphablending($image, TRUE);"
270 | ERROR | There must be no blank line following an inline comment
271 | ERROR | Whitespace found at end of line
272 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
276 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
281 | ERROR | Whitespace found at end of line
284 | ERROR | Whitespace found at end of line
288 | ERROR | No space before comment text; expected "//
| | imagealphablending($image, FALSE);" but found
| | "//imagealphablending($image, FALSE);"
289 | ERROR | No space before comment text; expected "//
| | imagesavealpha($image, TRUE);" but found
| | "//imagesavealpha($image, TRUE);"
291 | ERROR | Whitespace found at end of line
298 | WARNING | A comma should follow the last multiline array item. Found:
| | BLIZZARDAPI_TABARD_MAX_SIZE
300 | ERROR | Whitespace found at end of line
307 | WARNING | A comma should follow the last multiline array item. Found:
| | $height
310 | ERROR | Whitespace found at end of line
319 | ERROR | Whitespace found at end of line
330 | ERROR | Whitespace found at end of line
334 | ERROR | Whitespace found at end of line
338 | ERROR | Whitespace found at end of line
340 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------
FILE: ...s/all/modules/pareview_temp/test_candidate/includes/blizzardapi.wow.inc
--------------------------------------------------------------------------------
FOUND 30 ERROR(S) AND 10 WARNING(S) AFFECTING 36 LINE(S)
--------------------------------------------------------------------------------
5 | ERROR | Whitespace found at end of line
12 | ERROR | Protected member variable "_schema" must not be
| | prefixed with an underscore
28 | WARNING | A comma should follow the last multiline array item. Found:
| | 'quests'
29 | WARNING | A comma should follow the last multiline array item. Found: )
31 | ERROR | Whitespace found at end of line
32 | ERROR | Missing function doc comment
35 | WARNING | A comma should follow the last multiline array item. Found:
| | LANGUAGE_DEFAULT
37 | ERROR | Whitespace found at end of line
42 | ERROR | Whitespace found at end of line
44 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
44 | ERROR | There must be no blank line following an inline comment
44 | ERROR | Comments may not appear after statements.
45 | ERROR | Whitespace found at end of line
46 | WARNING | Line exceeds 80 characters; contains 87 characters
46 | ERROR | No space before comment text; expected "//
| | $this->fields['fields'] = $fields; // @todo Run fields
| | through a $_schema check." but found
| | "//$this->fields['fields'] = $fields; // @todo Run fields
| | through a $_schema check."
57 | ERROR | Whitespace found at end of line
62 | ERROR | Whitespace found at end of line
65 | ERROR | Whitespace found at end of line
68 | ERROR | Whitespace found at end of line
69 | ERROR | Private member variable "_schema" must not be
| | prefixed with an underscore - it is discouraged in PHP
| | 5-specific code
74 | WARNING | A comma should follow the last multiline array item. Found:
| | TYPE_RPPVP
79 | WARNING | A comma should follow the last multiline array item. Found:
| | POPULATION_HIGH
83 | WARNING | A comma should follow the last multiline array item. Found:
| | STATUS_ONLINE
87 | WARNING | A comma should follow the last multiline array item. Found:
| | QUEUE_YES
88 | WARNING | A comma should follow the last multiline array item. Found: )
90 | ERROR | Whitespace found at end of line
91 | ERROR | Missing function doc comment
94 | WARNING | A comma should follow the last multiline array item. Found:
| | LANGUAGE_DEFAULT
96 | ERROR | Whitespace found at end of line
100 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
100 | ERROR | Comments may not appear after statements.
102 | ERROR | Whitespace found at end of line
103 | ERROR | You must use "/**" style comments for a function comment
109 | ERROR | Whitespace found at end of line
110 | ERROR | Missing function doc comment
116 | ERROR | Whitespace found at end of line
117 | ERROR | Missing function doc comment
123 | ERROR | Whitespace found at end of line
124 | ERROR | Missing function doc comment
130 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------
Source: http://ventral.org/pareview - PAReview.sh online service
